Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add talkSPORT app, Times Radio app and Virgin Radio app from v1 #17

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

steffengr
Copy link
Contributor

Add apps that were in the old user-agents project but are missing here. I'm not sure if there was a reason for not migrating these entries but we are observing some traffic with them that is not matching to ExoPlayerLib instead.

Add apps that were in the old user-agents project but are missing here.
@johnspurlock johnspurlock merged commit 9e6b194 into opawg:master Jan 25, 2024
1 check passed
@johnspurlock
Copy link
Contributor

Thanks! These can be simplified (no longer need the Android-or-not distinction at each app level), but I can do that in a followup commit.

@johnspurlock
Copy link
Contributor

Simplification here: 3df50ba

@steffengr
Copy link
Contributor Author

Great thank you! Just copied them over without thinking about them.

@steffengr
Copy link
Contributor Author

@johnspurlock I ran our data against the latest files and still have some user agents from talkSPORT not matching. The user agent in these cases looks like this: talkSport/45.2.1./iOS 17.2.1/iPhone iPhone. The rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants